Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calculate boiler usage #153

Merged
merged 3 commits into from
Feb 28, 2024
Merged

Calculate boiler usage #153

merged 3 commits into from
Feb 28, 2024

Conversation

jkwan2011
Copy link
Collaborator

@jkwan2011 jkwan2011 commented Feb 28, 2024

Addresses #139 and #68.

jkwan2011 and others added 3 commits February 28, 2024 01:20
Co-authored-by: thatoldplatitude <[email protected]>
Co-authored-by: dwindleduck <[email protected]>
Co-authored-by: Alan Pinkert <[email protected]>
Co-authored-by: Debajyoti Debnath <[email protected]>
Co-authored-by: David Egan <[email protected]>
Co-authored-by: Chad Stoughton <[email protected]>
Added unit test for calculate_dhw_usage
@jkwan2011 jkwan2011 requested a review from alanisaac February 28, 2024 02:03
@alanisaac alanisaac merged commit 11748ee into main Feb 28, 2024
12 checks passed
@jkwan2011 jkwan2011 deleted the calculate_boiler_usage branch February 28, 2024 02:11
AdamFinkle pushed a commit to AdamFinkle/home-energy-analysis-tool that referenced this pull request May 22, 2024
* Implemented calculate_boiler_usage for fuel oil

Co-authored-by: thatoldplatitude <[email protected]>
Co-authored-by: dwindleduck <[email protected]>
Co-authored-by: Alan Pinkert <[email protected]>
Co-authored-by: Debajyoti Debnath <[email protected]>
Co-authored-by: David Egan <[email protected]>
Co-authored-by: Chad Stoughton <[email protected]>

* Renamed _calculate_boiler_usage to calculate_dhw_usage
Added unit test for calculate_dhw_usage

* Fixed static checks

---------

Co-authored-by: thatoldplatitude <[email protected]>
Co-authored-by: dwindleduck <[email protected]>
Co-authored-by: Alan Pinkert <[email protected]>
Co-authored-by: Debajyoti Debnath <[email protected]>
Co-authored-by: David Egan <[email protected]>
Co-authored-by: Chad Stoughton <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants